Skip to content

fix: make $effect.tracking consistent between in and out transitions #13774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rare-apes-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: make `$effect.tracking` consistent between in and out transitions
26 changes: 18 additions & 8 deletions packages/svelte/src/internal/client/reactivity/effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import {
set_is_destroying_effect,
set_is_flushing_effect,
set_signal_status,
untrack
untrack,
set_active_effect
} from '../runtime.js';
import {
DIRTY,
Expand Down Expand Up @@ -518,14 +519,23 @@ export function pause_effect(effect, callback) {
* @param {() => void} fn
*/
export function run_out_transitions(transitions, fn) {
var remaining = transitions.length;
if (remaining > 0) {
var check = () => --remaining || fn();
for (var transition of transitions) {
transition.out(check);
let prev_active_effect = active_effect;
let prev_active_reaction = active_reaction;
set_active_reaction(null);
set_active_effect(null);
try {
var remaining = transitions.length;
if (remaining > 0) {
var check = () => --remaining || fn();
for (var transition of transitions) {
transition.out(check);
}
} else {
fn();
}
} else {
fn();
} finally {
set_active_effect(prev_active_effect);
set_active_reaction(prev_active_reaction);
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { flushSync } from '../../../../src/index-client.js';
import { test } from '../../test';

export default test({
test({ assert, target, logs }) {
const btn = target.querySelector('button');
flushSync(() => {
btn?.click();
});
assert.deepEqual(logs, [false]);
flushSync(() => {
btn?.click();
});
assert.deepEqual(logs, [false, false]);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<script>
let visible = $state(0);

function in_and_out() {
console.log($effect.tracking());
}
</script>

<button onclick={() => visible = !visible}></button>

{#if visible}
<div transition:in_and_out></div>
{/if}