Skip to content

fix: ensure snippets after empty text correctly hydrate #13870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 24, 2024

Fixes #13852. We needed to pass through is_text like we do in other traversal operations for hydration to properly capture the empty text node.

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: c8cb320

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 42ccdc1 into main Oct 24, 2024
7 checks passed
@Rich-Harris Rich-Harris deleted the hydration-snippet branch October 24, 2024 21:21
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when snippet is next to empty text expression
3 participants