Skip to content

chore: mark markdown output from process-messages as generated #13913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Conduitry
Copy link
Member

We're marking the generated js files as generated; it would be nice to mark the markdown files as well.

Hopefully this doesn't confuse the site when it gets consumed. I haven't tested that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 3c3e566

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

pnpm add https://pkg.pr.new/svelte@13913

commit: 3c3e566

@dummdidumm
Copy link
Member

They're already in a .generated folder, is that not enough for you?

@Conduitry
Copy link
Member Author

I don't have an especially strong opinion about this. This PR arose from me doing a global search in the repo for ... something, I no longer remember what. And when I was looking at these files, I didn't actually notice that they had .generated in the path. I just noticed that there were several search results for what I was looking for, and some of the files I shouldn't be editing had a note at the top of them telling me that, and other files I shouldn't be editing did not.

@Rich-Harris Rich-Harris merged commit 2ab7004 into sveltejs:main Nov 1, 2024
9 checks passed
@Rich-Harris
Copy link
Member

seems reasonable

@Conduitry Conduitry deleted the mark_processed_messages_as_generated branch November 1, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants