Skip to content

Fix v4 site links #13992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 28, 2024
Merged

Fix v4 site links #13992

merged 7 commits into from
Oct 28, 2024

Conversation

Rich-Harris
Copy link
Member

this should be the last step before we're able to publish v4 docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc321b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Conduitry
Conduitry reviewed Oct 28, 2024
View reviewed changes
sites/svelte.dev/src/routes/_components/Example.svelte Outdated
@@ -11,7 +11,7 @@

$: {
if (repl) {
fetch(`/examples/api/${id}.json`)
fetch(`https://svelte.dev/playground/api/${id}.json`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these endpoints allow CORS?

This also seems like it would make the main site's examples appear here in the v4 site, which we presumably don't want to do, because they'd have runes syntax. I think we need to be doing something else here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove the examples section then 😄 it's not like this landing page needs to sell anything anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a nice easy solution dc321b2

@dummdidumm dummdidumm merged commit 8a661d9 into svelte-4 Oct 28, 2024
5 of 7 checks passed
@dummdidumm dummdidumm deleted the fix-v4-site-links branch October 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rich-Harris @dummdidumm @Conduitry