Skip to content

docs : add an example of using dynamic components #13993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

Devr-pro
Copy link
Contributor

Closes #13990

Adds a example of dynamic component usage with the help of {#await...} syntax

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Closes sveltejs#13990

Adds a example of dynamic component usage with the help of {#await...} syntax
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 0fd4791

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 28, 2024

pnpm add https://pkg.pr.new/svelte@13993

commit: 0fd4791

@Devr-pro
Copy link
Contributor Author

Devr-pro commented Oct 28, 2024

@dummdidumm Wouldn't it be better to add the note regarding .default ? Since its something changed since v4

@dummdidumm
Copy link
Member

What has changed in that regard? Svelte 4 also did provide its component via the default export, also it's visible in the code snippet already.

@Devr-pro
Copy link
Contributor Author

What has changed in that regard? Svelte 4 also did provide its component via the default export, also it's visible in the code snippet already.

Ahh yes, my bad
looks great now.

@benmccann benmccann changed the title Docs : add a illustration/sub-section for using dynamic components docs : add an example of using dynamic components Oct 28, 2024
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 6a1b5dd into sveltejs:main Oct 31, 2024
9 checks passed
@Devr-pro Devr-pro deleted the patch-1 branch October 31, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs : show or illustrate simple example for dynamic components in {#await} template section
3 participants