docs: fix docs on mutating props #14079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs added in #13994 are helpful but also somewhat misleading: the message should be a loud and clear 'don't mutate props' followed by details and examples, rather than an illustration of mutating a prop that does work but without mentioning the warning that happens when you do.
There were also some errors in the code snippets, which is really a consequence of a) the fact that we have to manually keep snippets and playground links in sync, and b) the fact that we don't have typechecking of
.svelte
snippets (which would have caught theobject = { count = 0 }
syntax error, for example). We should fix both of those.