Skip to content

chore: simplify signal capturing logic #14281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 12, 2024

Not sure why we need the extra variable. We can also simplify it a bit without needing it.

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: bfa7f9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14281

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14281-svelte.vercel.app/

this is an automated message

@Rich-Harris Rich-Harris merged commit 25d9aa1 into main Nov 13, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the simplify-signal-capturing branch November 13, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants