Skip to content

chore: globally install corepack #15734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

trivikr
Copy link

@trivikr trivikr commented Apr 11, 2025

Corepack is not going to be distributed with Node.js v25+
TSC vote nodejs/TSC#1697 (comment)

This PR updates the command to globally installing corepack.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 35aa0f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@Rich-Harris
Copy link
Member

Thank you. Is there a reason to prefer this over using pnpm/action-setup? Presumably that's a more direct path to the same outcome?

@trivikr
Copy link
Author

trivikr commented Apr 11, 2025

Is there a reason to prefer this over using pnpm/action-setup?

I don't know. I primarily use yarn, and not pnpm.

I just checked for popular projects on GitHub which use corepack enable, and posted PRs (like this one) as a suggestion before they break in Node.js 25+.

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15734

@Rich-Harris
Copy link
Member

I merged #15744 which uses pnpm directly (and aligns this workflow with the others in the repo), so I'll close this — thank you for the prod!

@trivikr trivikr deleted the patch-1 branch April 12, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants