fix: set and flushSync state that should render in if when another state is set breaks reactivity temporarily #16077
+86
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltejs#15895) * chore: avoid microtasks when flushing sync * chore: avoid microtasks when flushing sync * chore: avoid microtasks when flushing sync * tweak * WIP * another * more * tweak * fix * fix * belt and braces * Revert "belt and braces" This reverts commit f8de1cf. --------- Co-authored-by: Dominic Gannaway <[email protected]>" This reverts commit b616412.
# Conflicts: # packages/svelte/src/internal/client/runtime.js
🦋 Changeset detectedLatest commit: 9c0a31f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
raythurnvoid
changed the title
raythurnvoid
changed the title
|
This fixes #16076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i'm restoring the
flushSyncoptimization introduced in #15855 that was replaced by #15895.I reverted #15895 and adapted #15855 to the more recent changes of
flushSyncIn particular the problem seems to be that setting
is_flushingtotruebefore callingflush_tasksprevents the reactivity to work normally when a state is update in a
flushSyncand that same value is used in anif blockthat should be rendered after setting anotherstateright after theflushSync.Here are relevant playgrounds:
Before the regression
https://svelte.dev/playground/a89aaf76146c4571a996d7cd02e39d2f?version=5.28.2
When the regression was introduced
https://svelte.dev/playground/a89aaf76146c4571a996d7cd02e39d2f?version=5.28.3
Actual version, still broken
https://svelte.dev/playground/a89aaf76146c4571a996d7cd02e39d2f?version=5.33.14
Unfortunately I failed to reproduce the issue in the jsdom env, however it can be clearly tested both with
sv createand in the playground.Do you plan to upgrade vitest and switch to browser mode in the future?
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint