Skip to content

site: document a gotcha when using on: and bind: together #5166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mindrones
Copy link
Member

Closes #4616

@pngwn
Copy link
Member

pngwn commented Jul 29, 2020

We don't want to be adding 'gotcha' sections to the docs, and also I don't think this needs it's own example.

This isn't a gotcha, it is a feature that was implemented to solve a problem. I think we need to remove the example and add a 'pullout' in the docs explaining that directives that interact with DOM nodes are run in the order that they are defined. This gives you the flexibility to control the flow.

Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @pngwn. This should be explained as a feature (which it is), and not as a gotcha that we can't be bothered to do anything about.

I also don't think this warrants its own tutorial page.

@Conduitry Conduitry marked this pull request as draft August 5, 2020 15:52
@Conduitry Conduitry closed this Aug 12, 2020
@Conduitry Conduitry deleted the 4616_bind_on_order branch August 12, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two-way binding on:change and bind:value inconsistency depending on definition order
4 participants