[docs] Add missing parent <div> element to code example in each block bindings tutorial #7309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous commit, the missing `{#each}` tags were restored, which is helpful -- but it left out the `<div>` that wraps the `<input>`s. If a reader were copying from the example into the workspace, they would notice the styles breaking as a result. This change is intended to clarify that the parent `<div>` element should remain intact.
bluwy
approved these changes
Feb 25, 2022
|
My pleasure! Thanks for the quick review and the great docs! |
himanshiLt
pushed a commit
to himanshiLt/svelte
that referenced
this pull request
Mar 3, 2022
The div is part of the code, but not part of the code snippet of the text
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Mar 14, 2022
The div is part of the code, but not part of the code snippet of the text
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
The div is part of the code, but not part of the code snippet of the text
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
The div is part of the code, but not part of the code snippet of the text
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 22, 2022
The div is part of the code, but not part of the code snippet of the text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small correction to the "each block bindings" tutorial. I believe this PR is in line with the contribution guidelines, but I'm new here, so apologies if anything's off.
I'm working through the Svelte tutorial -- which is great, by the way! -- and noticed a small inconsistency between the displayed example code and the "after" code state that's intended. This PR updates the example code to match the expected result.
In the previous commit on this file, the missing
{#each}tags were restored to this example code, which is helpful -- but it left out the<div>that wraps the<input>s. If a reader were copying from the example into the workspace, they would notice the styles breaking as a result. This change is intended to clarify that the parent<div>element should remain intact.Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint