Skip to content

docs: add component comments #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

metonym
Copy link
Contributor

@metonym metonym commented Mar 19, 2022

I find @component comments to be highly useful. I actually wasn't aware it was supported by the Svelte Language Server until recently.

When visiting the documentation site, I cannot find documentation on component comments using a command + f search. Currently, component comments are only documented in the FAQs section.

This PR adds documentation for component comments to the Comments section.

dummdidumm
dummdidumm previously approved these changes Mar 19, 2022
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, seems like a good thing to document!

@Conduitry
Copy link
Member

My gut instinct is that, until we have more documentation of ancillary tooling on svelte.dev, that this isn't the sort of thing that should live here. It's not part of the core Svelte language, and the compiler ignores it. If this is documented somewhere else, like in the language tools repo somewhere, I could get behind having a link to that.

I know at some point we had a vision of separate tabs on the svelte.dev site for all of the different official bits of tooling (generated in some way from markdown files in individual repos), but I'm not sure whether that's still something we see happening now that we've moved away from the centralized docs API.

@benmccann benmccann changed the title [docs] add component comments docs: add component comments Mar 14, 2023
@dummdidumm dummdidumm added this to the one day milestone Mar 20, 2023
@dummdidumm dummdidumm dismissed their stale review March 20, 2023 13:15

unclear if/where this should land

@benmccann
Copy link
Member

My gut instinct is that, until we have more documentation of ancillary tooling on svelte.dev, that this isn't the sort of thing that should live here.

In my mind this is part of the Svelte spec and so it does belong here. There are a number of different tools that may have to understand this syntax. Documenting it just for a single tool doesn't seem sufficient. Those tools should probably link back to docs living here instead

@benmccann benmccann modified the milestones: one day, 4.x Sep 15, 2023
@metonym metonym force-pushed the docs-component-comments branch from 8de4ec1 to 517a35c Compare September 19, 2023 18:21
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

⚠️ No Changeset found

Latest commit: 19345d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@metonym
Copy link
Contributor Author

metonym commented Sep 19, 2023

I've rebased on master.

metonym and others added 2 commits September 19, 2023 11:58
Co-authored-by: Ben McCann <[email protected]>
@benmccann benmccann modified the milestones: 4.x, 5.x Sep 19, 2023
@Rich-Harris Rich-Harris merged commit 6045028 into sveltejs:svelte-4 Dec 3, 2024
@Rich-Harris
Copy link
Member

belated thanks!

@benmccann
Copy link
Member

@metonym unfortunately this PR accidentally got merged into the svelte-4 branch, which means no one will see it. We'll need to the changes copied to main for them to actually go live. I filed an issue for that here: #14560. If you're interested, please feel free to send a PR and hopefully we can finally get this change out

@metonym
Copy link
Contributor Author

metonym commented Dec 4, 2024

@benmccann Thanks for the heads up. I just checked the current live Svelte docs, and it seems that documentation for @component has already been added, so perhaps we can forgo this.

https://svelte.dev/docs/svelte/basic-markup#Comments

@benmccann
Copy link
Member

oh, great! I missed that. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants