Skip to content

fix(version-4): Link API to website #8729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 21, 2023
Merged

fix(version-4): Link API to website #8729

merged 10 commits into from
Jun 21, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Jun 13, 2023

Fixes existing links to documentation in the public API JSDoc and adds corresponding link for all public API

@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) Jun 13, 2023 11:14pm

@PuruVJ PuruVJ changed the base branch from master to version-4 June 13, 2023 19:07
@PuruVJ PuruVJ marked this pull request as draft June 13, 2023 19:08
@PuruVJ PuruVJ marked this pull request as ready for review June 13, 2023 19:44
@benmccann benmccann added this to the 4.x milestone Jun 13, 2023
benmccann
benmccann reviewed Jun 13, 2023
View reviewed changes
@benmccann benmccann requested a review from Rich-Harris June 19, 2023 15:46
dummdidumm
dummdidumm reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove duplicated docs (so we don't have to maintain them in multiple places which is prone to get out of sync), otherwise 👍

dummdidumm
dummdidumm approved these changes Jun 20, 2023
View reviewed changes
@PuruVJ
Copy link
Collaborator Author

PuruVJ commented Jun 20, 2023

Vercel is building finally. Is the test error related to this somehow? If not, feel free to merge

@dummdidumm
Copy link
Member

Tests need updating then we can merge

@benmccann benmccann deleted the branch master June 20, 2023 20:45
@benmccann benmccann closed this Jun 20, 2023
@dummdidumm dummdidumm reopened this Jun 20, 2023
@dummdidumm dummdidumm changed the base branch from version-4 to master June 20, 2023 20:50
@dummdidumm dummdidumm merged commit 7874910 into master Jun 21, 2023
@dummdidumm dummdidumm deleted the fix/point-links-new-website branch June 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@dummdidumm dummdidumm dummdidumm approved these changes

@Rich-Harris Rich-Harris Awaiting requested review from Rich-Harris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PuruVJ @dummdidumm @benmccann