Skip to content

feat(site): site-kit renderer #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 22, 2023
Merged

feat(site): site-kit renderer #8757

merged 12 commits into from
Jun 22, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Jun 18, 2023

Moves renderer and markdown to site-kit, where it can be used by kit as well

@benmccann benmccann deleted the branch master June 20, 2023 20:45
@benmccann benmccann closed this Jun 20, 2023
@dummdidumm dummdidumm reopened this Jun 20, 2023
@dummdidumm dummdidumm changed the base branch from version-4 to master June 20, 2023 20:50
@benmccann
Copy link
Member

@PuruVJ it looks like this one has a merge conflict

@PuruVJ PuruVJ marked this pull request as ready for review June 21, 2023 21:12
@PuruVJ PuruVJ changed the title feat(sites): site-kit renderer feat(site): site-kit renderer Jun 21, 2023
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the righthand sidebar looks broken with this change

Screenshot from 2023-06-21 15-05-32

@PuruVJ PuruVJ merged commit 22cc475 into master Jun 22, 2023
@PuruVJ PuruVJ deleted the feat/sitekit-renderer branch June 22, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants