-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Version info thingy #8761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version info thingy #8761
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
53009cb
version info thingy
gtm-nayan aacec5b
fix opt-out and tests
gtm-nayan 2e4ba15
use a more obscure name with an array
gtm-nayan 039c060
whoops
gtm-nayan edf487d
formatting
gtm-nayan 9e7b2ab
use extension
gtm-nayan 1fb6dcc
rename to internal/tag-version
gtm-nayan e2cefd0
use Set
gtm-nayan 1bc1949
whoops
gtm-nayan a05c6f2
changeset
gtm-nayan 9ad62f3
Update .changeset/yellow-squids-explain.md
dummdidumm f259061
Update .changeset/yellow-squids-explain.md
gtm-nayan aad1ea3
rename option
gtm-nayan 205fc8c
fix default, golf things a bit, only major version
gtm-nayan d5f97bf
actually hide the rest of the version and rename entrypoint
gtm-nayan b2a0f8a
syntax compatibility
gtm-nayan c719fea
Merge branch 'master' into version-info-thingy
gtm-nayan 7bb5bf8
Merge remote-tracking branch 'upstream/master' into version-info-thingy
gtm-nayan d121960
let esbuild handle resolution
gtm-nayan ffd543a
Update packages/svelte/src/compiler/interfaces.d.ts
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte': patch | ||
--- | ||
|
||
feat: add version info to `window`. You can opt out by setting `discloseVersion` to `false` in the compiler options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
<script> | ||
import Counter from "./lib/Counter.svelte"; | ||
</script> | ||
|
||
<div> | ||
Hello world! | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/svelte/src/runtime/internal/disclose-version/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { PUBLIC_VERSION } from '../../../shared/version.js'; | ||
|
||
if (typeof window !== 'undefined') | ||
// @ts-ignore | ||
(window.__svelte || (window.__svelte = { v: new Set() })).v.add(PUBLIC_VERSION); | ||
dummdidumm marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ | |
* @type {string} | ||
*/ | ||
export const VERSION = '4.0.0-next.2'; | ||
export const PUBLIC_VERSION = '4'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.