Skip to content

docs: Make transition global in Deferred transition example #9020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

docs: Make transition global in Deferred transition example #9020

merged 1 commit into from
Jul 21, 2023

Conversation

Posandu
Copy link
Contributor

@Posandu Posandu commented Jul 21, 2023

Svelte 4 uses local for transitions by default. changelog. Therefore, the deferred transition example doesn't work. I fixed it

Before

Recording.2023-07-21.224422.mp4

After

Recording.2023-07-21.224422.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: 9aaab44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoffrich geoffrich merged commit 7af165d into sveltejs:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants