Skip to content

docs: Fix a regression for a quoted-attribute example #9103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

andy0130tw
Copy link
Contributor

The code example is inconsistent with the text:

An expression might include characters that would cause syntax highlighting to fail in regular HTML, so quoting the value is permitted. The quotes do not affect how the value is parsed: [...]

But the attribute in the code example is not quoted at all:

<button disabled={number !== 42}>...</button>

This small PR fixes the code example by placing back missing quotation marks.

It is a regression, as the docs before site redesign explain it correctly; see https://github.com/sveltejs/svelte/blob/v3.59.2/site/content/docs/03-template-syntax.md.


Before submitting the PR, please make sure you do the following

  • [v] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [v] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [v] This message body should clearly illustrate what problems it solves.
  • (N/A) Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [v] Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2023

⚠️ No Changeset found

Latest commit: 4020bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PuruVJ
Copy link
Collaborator

PuruVJ commented Aug 13, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants