Skip to content

site: fix rendering of promise in deprecation warning #9191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2023
Merged

site: fix rendering of promise in deprecation warning #9191

merged 4 commits into from
Sep 13, 2023

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Sep 9, 2023

Fixes #9190

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2023

⚠️ No Changeset found

Latest commit: d9f61d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann
benmccann reviewed Sep 10, 2023
View reviewed changes
documentation/docs/02-template-syntax/07-special-elements.md
@@ -200,7 +200,6 @@ If `this` is the name of a [void element](https://developer.mozilla.org/en-US/do
<script>
let tag = 'div';

/** @type {(e: MouseEvent) => void} */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this have to be removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is erroring with this line for some reason. Something deeper in the code itself, but 2 hours of debugging didn't reveal the main issue

@benmccann benmccann changed the title fix: unresolved promise deprecated site: fix rendering of promise in deprecation warning Sep 10, 2023
@benmccann benmccann merged commit 49df010 into feat/copy-code-button Sep 13, 2023
@benmccann benmccann deleted the chore/fix-unresolved-promise-deprecated branch September 13, 2023 15:36
PuruVJ added a commit that referenced this pull request Sep 16, 2023
@PuruVJ
feat: Copy code button (#8995)
1a28d58 
* Push

* Bump site-kit

* Add headers to primary snippets

* Update deps

* Bump deos

* redploy

* Back to normal

* Push

* Bump deps

* site: fix rendering of promise in deprecation warning (#9191)

* copy: true

* Bump site-kit

* Use cache
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
@PuruVJ @kelvinsjk
feat: Copy code button (sveltejs#8995)
a914f39 
* Push

* Bump site-kit

* Add headers to primary snippets

* Update deps

* Bump deos

* redploy

* Back to normal

* Push

* Bump deps

* site: fix rendering of promise in deprecation warning (sveltejs#9191)

* copy: true

* Bump site-kit

* Use cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PuruVJ @benmccann