Skip to content

chore: use internal get_descriptors helper #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2023
Merged

chore: use internal get_descriptors helper #9389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5402a2a
chore: use internal get_descriptors helper
Rich-Harris Nov 11, 2023
ad0fef3
tweak changeset
Rich-Harris Nov 11, 2023
085f902
Merge branch 'main' into use-get-descriptors
Rich-Harris Nov 13, 2023
5aba9ac
Merge branch 'main' into use-get-descriptors
Rich-Harris Nov 13, 2023
f2b35fd
fix bad merge
Rich-Harris Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-walls-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: use internal `get_descriptors` helper
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ import {
hydrate_block_anchor,
set_current_hydration_fragment
} from './hydration.js';
import { array_from, define_property, get_descriptor, is_array } from './utils.js';
import { array_from, define_property, get_descriptor, get_descriptors, is_array } from './utils.js';
import { is_promise } from '../common.js';
import { bind_transition } from './transitions.js';

Expand Down Expand Up @@ -2824,7 +2824,7 @@ function get_setters(element) {
/** @type {string[]} */
const setters = [];
// @ts-expect-error
const descriptors = Object.getOwnPropertyDescriptors(element.__proto__);
const descriptors = get_descriptors(element.__proto__);
for (const key in descriptors) {
if (descriptors[key].set && !always_set_through_set_attribute.includes(key)) {
setters.push(key);
Expand Down