Skip to content

site: allow multiple blog authors #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

geoffrich
Copy link
Member

Opened against the svelte-4 branch since I think that's the only one where site deploys work, but lmk if it should be main instead.

This PR allows specifying multiple authors on a blog post by adding comma separation in the frontmatter, e.g.

---
title: Streaming, snapshots, and other new features since SvelteKit 1.0
description: Exciting improvements in the latest version of SvelteKit
author: Geoff Rich, Rich Harris
authorURL: https://geoffrich.net, https://twitter.com/Rich_Harris
---

Updated the streaming blog post from earlier this year to give credit to Rich, since he wrote the "how does this work" section.

image

@geoffrich geoffrich requested a review from dummdidumm November 11, 2023 19:57
Copy link

changeset-bot bot commented Nov 11, 2023

⚠️ No Changeset found

Latest commit: dd64aac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

I wonder if we should use a different delimiter like ; or | so that we don't break in case someone writes their name like Doe, John or John Doe, MD, PhD

@Rich-Harris
Copy link
Member

I'm inclined to file that under 'cross that bridge when we come to it'

@Rich-Harris Rich-Harris merged commit 022c47e into svelte-4 Nov 12, 2023
@Rich-Harris Rich-Harris deleted the grich/multi-blog-authors branch November 12, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants