Skip to content

enable dev mode for preview repl #9393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sites/svelte-5-preview/src/lib/Output/CompilerOptions.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!-- svelte-ignore a11y-label-has-associated-control -->
<script>
import { get_repl_context } from '$lib/context.js';
import Checkbox from '../Checkbox.svelte';

const { compile_options } = get_repl_context();
</script>
Expand All @@ -16,6 +17,12 @@
<input id="server" type="radio" bind:group={$compile_options.generate} value="server" />
<label for="server"><span class="string">"server"</span>,</label>
</div>

<label class="option">
<span class="key">dev:</span>
<Checkbox bind:checked={$compile_options.dev} />
<span class="boolean">{$compile_options.dev}</span>,
</label>
});
</div>

Expand Down
3 changes: 2 additions & 1 deletion sites/svelte-5-preview/src/lib/Repl.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@

/** @type {import('svelte/compiler').CompileOptions} */
const DEFAULT_COMPILE_OPTIONS = {
generate: 'client'
generate: 'client',
dev: false
};

/** @type {Map<string, import('@codemirror/state').EditorState>} */
Expand Down
11 changes: 8 additions & 3 deletions sites/svelte-5-preview/src/lib/workers/bundler/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,8 @@ async function get_bundle(uid, mode, cache, local_files_lookup) {
} else if (id.endsWith('.svelte')) {
result = svelte.compile(code, {
filename: name + '.svelte',
generate: 'client'
generate: 'client',
dev: true
});

if (result.css) {
Expand All @@ -400,7 +401,11 @@ async function get_bundle(uid, mode, cache, local_files_lookup) {
`.replace(/\t/g, '');
}
} else if (id.endsWith('.svelte.js')) {
result = svelte.compileModule(code, { filename: name + '.js', generate: 'client' });
result = svelte.compileModule(code, {
filename: name + '.js',
generate: 'client',
dev: true
});
if (!result) {
return null;
}
Expand All @@ -420,7 +425,7 @@ async function get_bundle(uid, mode, cache, local_files_lookup) {
warnings.push(warning);
});

/** @type {import('rollup').TransformResult} */
/** @type {import('@rollup/browser').TransformResult} */
const transform_result = {
code: result.js.code,
map: result.js.map
Expand Down
6 changes: 4 additions & 2 deletions sites/svelte-5-preview/src/lib/workers/compiler/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function compile({ id, source, options, return_ast }) {
if (options.filename.endsWith('.svelte')) {
const compiled = svelte.compile(source, {
filename: options.filename,
generate: options.generate
generate: options.generate,
dev: options.dev
});

const { js, css, warnings, metadata } = compiled;
Expand All @@ -77,7 +78,8 @@ function compile({ id, source, options, return_ast }) {
} else if (options.filename.endsWith('.svelte.js')) {
const compiled = svelte.compileModule(source, {
filename: options.filename,
generate: options.generate
generate: options.generate,
dev: options.dev
});

if (compiled) {
Expand Down
9 changes: 9 additions & 0 deletions sites/svelte-5-preview/src/lib/workers/jsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"include": ["./**/*"],
"compilerOptions": {
"paths": {
"svelte": ["../../../static/svelte/main"],
"svelte/*": ["../../../static/svelte/*"]
}
}
}