Tidy up analysis #9435
Closed
Tidy up analysis #9435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben McCann <[email protected]>
…to baseballyama-fix/private-field
🦋 Changeset detectedLatest commit: 4686a35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
the ideas here are still valid but there's not a lot that can be salvaged — closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
help me, i am in a rabbit hole
this started with me looking at #9394 and thinking 'hmm, the shared
ClassBodyfunction probably belongs in a set of common visitors' — it quickly became apparent that the code organisation right now is a bit woolly (it's hard to tell at a glance which visitors belong to which sets, and some stuff is duplicated unnecessarily), and it would be beneficial to introduce theanalyzeandanalyzeModulefunctions we discussed elsewhere (and divide up visitors accordingly)i am sorry for this PR. WIP