fix: fire afterUpdate even if dependencies are not used in template
#9442
Conversation
🦋 Changeset detectedLatest commit: df280ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -185,7 +185,7 @@ function init_update_callbacks() { | |||
| user_effect(() => { | |||
| called_before = false; | |||
| called_after = true; | |||
| untrack(() => update_callbacks.after.forEach(/** @param {any} c */ (c) => c())); | |||
| update_callbacks.after.forEach(/** @param {any} c */ (c) => c()); | |||
There was a problem hiding this comment.
I don't think this is the correct fix. This means that any signal reads inside update_callbacks are registered with our user_effect so it reruns whenever those change.
There was a problem hiding this comment.
Ah got it. I will re-fix it.
There was a problem hiding this comment.
I partly take that back - in order to fix all possible cases, we need to track the signals inside before/afterUpdate, but in a manner that they rerun at the correct time and not too often
There was a problem hiding this comment.
@dummdidumm Can you give me an example of an unnecessarily frequent rerun the before/afterUpdate?
baseballyama
force-pushed
the
fix/afterUpdate
branch
from
a47f02b to
f881e4a
Compare
|
Unfortunately this isn't the solution — it doesn't cover this case, where no signal is referenced: afterUpdate(() => {
console.log('updating');
});Closing in favour of #10408 |
close: #9420
I think it was wrapped in
untrackfor some reason, but I couldn't figure out why. I hope it is just an implementation error.Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4and notmain.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint