Skip to content

fix: allow setting files binding for <input type="file" /> (Svelte 5) #9463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-geese-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: allow setting files binding for `<input type="file" />`
1 change: 1 addition & 0 deletions packages/svelte/src/compiler/phases/bindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export const binding_properties = {
},
files: {
event: 'change',
type: 'set',
valid_elements: ['input'],
omit_in_ssr: true
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { test } from '../../assert';

export default test({
async test({ assert, window }) {
const input = window.document.querySelector('input');
await new Promise((r) => setTimeout(r, 100));
assert.equal(input?.files?.length, 1);
window.document.querySelector('button')?.click();
await new Promise((r) => setTimeout(r, 100));
assert.equal(input?.files?.length, 0);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<script>
import { onMount } from "svelte";

let files;

onMount(() => {
let list = new DataTransfer();
let file = new File(["content"], "filename.jpg");
list.items.add(file);
files = list.files;
})
</script>

<input type="file" bind:files />

<button onclick={() => files = new DataTransfer().files}>Reset</button>