fix: select enabled option with null value when it matches bound value #9550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@theodorejb is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
theodorejb
force-pushed
the
select-null-value-binding
branch
from
ce5d466 to
5e9a205
Compare
dummdidumm
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9545
Also corrected misspellings and significantly streamlined the select binding code.
This does not address #9517. For that to work it seems like some kind of hook which runs after options are removed from the DOM will be necessary. I'm not yet familiar enough with Svelte 5 internals to know how best to implement this.