Skip to content

site: remove banner #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2023
Merged

site: remove banner #9620

merged 3 commits into from
Nov 29, 2023

Conversation

hanszoons
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 23, 2023

⚠️ No Changeset found

Latest commit: e1d426d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 23, 2023

@hanszoons is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Rich-Harris
Copy link
Member

Thanks - we do need to get rid of the Nov 11 banner, but I'm not sure we should reinstate the old one. Banners should be short-lived

@hanszoons
Copy link
Contributor Author

Agreed, but the v5 preview is currently quite difficult to locate (even when you're aware of its existence!). Whether a banner is the appropriate medium for this, I'm not certain.

@benmccann
Copy link
Member

I'm not sure how much the average user needs to know about Svelte 5. Details are in our roadmap. I think we could surface other places as well if we could find an appropriate place, but we can probably handle that separately. For now I think the priority is probably removing the banner, which I agree we don't need anymore.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 0:29am

@benmccann
Copy link
Member

It might not be a bad idea to update the banner to say something like "Watch the recent Svelte Summit on YouTube". But we've already had the banner up for a couple weeks post-Summit and the current banner is highly annoying as it can't be closed until #9246 is merged, so I'll go ahead and remove the banner for now

@benmccann benmccann changed the title site: reinstate 'runes'-banner site: remove banner Nov 29, 2023
@benmccann benmccann merged commit 8c2cbb8 into sveltejs:main Nov 29, 2023
@dummdidumm dummdidumm mentioned this pull request Nov 29, 2023
benmccann added a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants