Skip to content

chore(site): simplify prettier commands #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2023
Merged

chore(site): simplify prettier commands #9703

merged 2 commits into from
Dec 3, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Nov 29, 2023

prettier is currently broken on the svelte-4 branch (no longer true since merging in the latest svelte-4 branch where prettier was updated thus fixing the issue)

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 265b995

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Nov 29, 2023

Prettier isn't broken, it's on 2.8 and not 3.0. I don't think we should change this. Very confused by the git diff, I have prettier 2.8 locally

@benmccann
Copy link
Member Author

Your local version must be behind:

"prettier": "^3.0.3",

@dummdidumm
Copy link
Member

I just did git pull and I got the banner changes from upstream - what's going on?

Edit: Oooh it seems that prettier is 2.8 at the root but 3.x in sites - we should probably align that.

@benmccann
Copy link
Member Author

I don't know that we need to reformat the entire Svelte 4 codebase. I think just fixing the site configuration is enough. We could remove prettier from the root package.json and just have it in the sub-projects if you think that'd be clearer

@benmccann benmccann changed the title fix(site): update prettier chore(site): simplify prettier commands Dec 3, 2023
@benmccann
Copy link
Member Author

The dependencies got fixed in another PR, so there's not much left on this PR. Now it's just simplifying the commands. I think any other prettier-related changes can be handled separately

Copy link
Collaborator

@PuruVJ PuruVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants