-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(site): simplify prettier commands #9703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Prettier isn't broken, it's on 2.8 and not 3.0. I don't think we should change this. Very confused by the git diff, I have prettier 2.8 locally |
Your local version must be behind: svelte/sites/svelte.dev/package.json Line 44 in 7a5176e
|
I just did Edit: Oooh it seems that prettier is 2.8 at the root but 3.x in |
I don't know that we need to reformat the entire Svelte 4 codebase. I think just fixing the site configuration is enough. We could remove prettier from the root package.json and just have it in the sub-projects if you think that'd be clearer |
The dependencies got fixed in another PR, so there's not much left on this PR. Now it's just simplifying the commands. I think any other prettier-related changes can be handled separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
prettier is currently broken on the(no longer true since merging in the latestsvelte-4
branchsvelte-4
branch where prettier was updated thus fixing the issue)