Skip to content

Do not ignore validation of referenced schemas #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2021
Merged

Do not ignore validation of referenced schemas #117

merged 2 commits into from
May 12, 2021

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented May 12, 2021

This PR enables strict schema dereferencing when target is clearly an instance of JSON schema.

Resolves #116.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #117 (c348881) into master (fa87be2) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     92.19%   92.27%   +0.07%     
- Complexity      753      754       +1     
============================================
  Files            27       27              
  Lines          1641     1643       +2     
============================================
+ Hits           1513     1516       +3     
+ Misses          128      127       -1     
Impacted Files Coverage Δ Complexity Δ
src/Schema.php 95.92% <100.00%> (+0.16%) 342.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa87be2...c348881. Read the comment docs.

@vearutop vearutop merged commit f92567a into master May 12, 2021
@vearutop vearutop deleted the issue-116 branch May 12, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized types appear to stop validation of other types, should throw exception?
1 participant