Permit installation when symfony/polyfill-mbstring is present #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 27 27
Lines 1686 1686
=======================================
Hits 1562 1562
Misses 124 124 Continue to review full report at Codecov.
|
|
Thank you! |
|
Thanks for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to require the
symfony/polyfill-mbstringpackage, instead of thembstringextension, to permit usage of this library on PHP server that does not have the extension loaded. For instance, it can happen on some shared hosting servers where users cannot choose which extension is installed.