ChannelRead because of closing connection: Remove preconditions #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-http-final-messages
branch
from
b2dc4ae to
4424dec
Compare
Lukasa
approved these changes
Sep 20, 2021
| @@ -536,16 +536,21 @@ struct HTTPRequestStateMachine { | |||
| assert(producerState == .paused, "Expected to have paused the request body stream, when the head was received. Invalid state: \(self.state)") | |||
|
|
|||
| return self.avoidingStateMachineCoW { state -> Action in | |||
| let remainingBuffer = responseStreamState.end() | |||
| let (remainingBuffer, _) = responseStreamState.end() | |||
There was a problem hiding this comment.
I think it would be good to explain in a comment why here and above you don't care about the second tuple element.
fabianfett
force-pushed
the
ff-http-final-messages
branch
from
4424dec to
1acdb0c
Compare
fabianfett
force-pushed
the
ff-http-final-messages
branch
from
596c58f to
2189eb6
Compare
Lukasa
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NIO may send
channelReadevents without a handlers requesting more data with acontext.read()invocation. This happens if the remote has closed the connection and NIO wants to inform the handlers as soon as possible.Changes
preconditiononchannelReadevents anymore.context.read()invocation