Fix flaky AsyncAwaitEndToEndTests.testImmediateDeadline
test
#698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed that
AsyncAwaitEndToEndTests.testImmediateDeadline
can also return aHTTPClientError.remoteConnectionClosed
in rare circumstances. If closing happens really fast we might shutdown the pipeline before we fail the request. If the pipeline is closed we may receive a.remoteConnectionClosed
which can execute before we push the previous error to the request state machine. We can't change this in the current architecture so we will just tolerate this error in tests as well.The
AsyncAwaitEndToEndTests.testDeadline()
is less likely to experience this issue but I have changed it there too just to be safe.