Add guards for code that relies on _Concurrency to allow compilation with Xcode 13 #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Xcode 13 to still compile on macOS 11 which does not have symbols for Concurrency yet See swift-server/swift-service-lifecycle#110
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
In case it's of interest, I also have another branch that applies a similar patch to main: https://github.com/programmarchy/swift-aws-lambda-runtime/tree/fix-xcode13 |
programmarchy
changed the title
|
Related: #234 |
tomerd
approved these changes
Oct 4, 2021
|
@swift-server-bot test this please |
|
@programmarchy could you reopen this against the v0 branch? we will track 0.x releases from that branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra code guards so that Xcode 13 will compile this package on macOS 11, which does not have symbols for Concurrency yet.
Motivation:
Allow compilation with Xcode 13
Modifications:
Changed code guards
#if compiler(>=5.5)to#if compiler(>=5.5) && canImport(_Concurrency)Got the idea from swift-server/swift-service-lifecycle#110
Result:
Successfully compiles with Xcode 13