KafkaProducer.makeProducerWithEvents() avoid fatalError
#117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
`KafkaProducer.makeeProducerWithEvents()`: initializing the
`NIOAsyncSequenceProducer
Modifications:
* make designated initializer of `KafkaProducer` non-throwing
* `KafkaProducer.makeProducerWithEvents`:
* initialize `client` before
calling `NIOAsyncSequenceProducer.makeSequence`
-> if initializing `client` fails the appropiate error gets thrown
instead of triggering a fatalError because
`KafkaProducerCloseOnTerminate` gets triggered in an invalid state
Result:
When the initialization `KafkaProducer.makeProducerWithEvents` fails an
error is thrown instead of triggering the `fatalError` in
`KafkaProducerCloseOnTerminate`.
felixschlegel
changed the title
KafkaProducer.makeeProducerWithEvents() avoid fatalErrorKafkaProducer.makeProducerWithEvents() avoid fatalError
blindspotbounty
approved these changes
Aug 21, 2023
FranzBusch
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
KafkaProducer.makeeProducerWithEvents(): initializing theNIOAsyncSequenceProducerbefore theclientand theclientinit throwing an erorr led toKafkaProducerCloseOnTerminategetting triggered in an invalid state which in turn resulted in afatalErrorModifications:
KafkaProducernon-throwingKafkaProducer.makeProducerWithEvents:clientbeforecalling
NIOAsyncSequenceProducer.makeSequence-> if initializing
clientfails the appropiate error gets throwninstead of triggering a fatalError because
KafkaProducerCloseOnTerminategets triggered in an invalid stateResult:
When the initialization
KafkaProducer.makeProducerWithEventsfails anerror is thrown instead of triggering the
fatalErrorinKafkaProducerCloseOnTerminate.