Ship with BoringSSL #135
Merged
Ship with BoringSSL #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: No need to install `libressl` on machine to build project. Modifications: * add dependency to `swift-nio-ssl` to obtain copy of `BoringSSL` * create bridging headers allowing `librdkafka` to build with `BoringSSL` copy from `swift-nio-ssl` Additional Changes: * use `swift-service-lifecycle` version `2.1.0` instead of `beta`
FranzBusch
reviewed
Oct 4, 2023
Modifications: * add `_GNU_SOURCE` macro to `Crdkafka` target to fix build error "error: '(anonymous struct)::__fds_bits' from module 'CNIOBoringSSL' is not present in definition of 'fd_set' provided earlier" for Swift 5.9 onwards
That's a weird one, I run into the exact issue as described here: Currently, my fix is to set the |
Co-authored-by: Franz Busch <[email protected]>
felixschlegel
force-pushed
the
fs-vendor-boring-ssl
branch
from
92f1da1 to
f074c2a
Compare
|
We need to get #137 merged before we get the |
FranzBusch
approved these changes
Oct 5, 2023
axelandersson
added a commit
to ordo-one/swift-kafka-client
that referenced
this pull request
Oct 5, 2023
…1005 * upstream/main: Ship with BoringSSL (swift-server#135) Add CI pipeline for Swift 5.10 (swift-server#137)
FranzBusch
added a commit
that referenced
this pull request
Nov 3, 2023
This reverts commit 5dbf2fa.
FranzBusch
added a commit
that referenced
this pull request
Nov 3, 2023
This reverts commit 5dbf2fa.
blindspotbounty
added a commit
to ordo-one/swift-kafka-client
that referenced
this pull request
Nov 29, 2023
This reverts commit 42c2972.
blindspotbounty
added a commit
to ordo-one/swift-kafka-client
that referenced
this pull request
Nov 29, 2023
This reverts commit 42c2972.
mimischi
added a commit
that referenced
this pull request
Feb 24, 2025
Updates `librdkafka` to the latest release 2.8.0. ### Motivation: The `librdkafka` version shipped by this client has gotten fairly old, and there's been a few releases with bug fixes. ### Modifications: A recent commit [1] added a function call that is not available in BoringSSL. This requires us moving away from BoringSSL again. [1] https://github.com/confluentinc/librdkafka/blame/93877617709eb071a0f4ec7038c54e2764abefc9/src/rdkafka_ssl.c#L1533 ### Result: * Updated `librdkafka` to 2.8.0. * Removed BoringSSL from project (introduced in #135) * `libssl-dev` now needs to be available during build time again. Closes #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123
Motivation:
No need to install
libresslon machine to build project.Modifications:
swift-nio-sslto obtain copy ofBoringSSLlibrdkafkato build withBoringSSLcopy fromswift-nio-sslAdditional Changes:
swift-service-lifecycleversion2.1.0instead ofbeta