Bump runtime to 1.0.0-alpha.1 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MahdiBM
commented
Nov 28, 2023
MahdiBM
commented
- Tests passed locally
MahdiBM
commented
Nov 28, 2023
| @@ -175,7 +175,7 @@ extension Vapor.Response.Body { | |||
| } | |||
| switch body.length { | |||
| case let .known(count): | |||
| self = .init(stream: stream, count: count) | |||
| self = .init(stream: stream, count: Int(clamping: count)) | |||
There was a problem hiding this comment.
watchOS still uses Int == Int32 so it might need to "clamp" an Int64 to an Int32.
There was a problem hiding this comment.
To be clear these changes are because the runtime now uses Int64 instead of Int, for the exact same watchOS reason.
MahdiBM
commented
Nov 28, 2023
| @@ -102,7 +102,7 @@ extension OpenAPIRuntime.HTTPBody { | |||
| let contentLength = vaporRequest.headers.first(name: "content-length").map(Int.init) | |||
| self.init( | |||
| vaporRequest.body.map(\.readableBytesView), | |||
| length: contentLength?.map { .known($0) } ?? .unknown, | |||
| length: contentLength?.map { .known(numericCast($0)) } ?? .unknown, | |||
There was a problem hiding this comment.
Int -> Int64 conversion which as of now should always succeed AFAIK.
MahdiBM
commented
Nov 28, 2023
| @@ -24,7 +24,7 @@ let package = Package( | |||
| .library(name: "OpenAPIVapor", targets: ["OpenAPIVapor"]) | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/apple/swift-openapi-runtime.git", .upToNextMinor(from: "0.3.0")), | |||
| .package(url: "https://github.com/apple/swift-openapi-runtime.git", exact: "1.0.0-alpha.1"), | |||
There was a problem hiding this comment.
exact: as Honza suggested.
0xTim
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.