Enable some compiler flags on Swift 5.9+ #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
reviewed
Nov 22, 2023
[email protected]
Outdated
| import PackageDescription | ||
|
|
||
| let swiftSettings: [SwiftSetting] = [ | ||
| .enableUpcomingFeature("ExistentialAny"), |
There was a problem hiding this comment.
Won't we need this in 5.8 to make the change compile?
There was a problem hiding this comment.
No, it works down until 5.7.
But I think we might be able to just drop 5.8 all together, the generator is already at 5.9+.
I need to check.
There was a problem hiding this comment.
Yeah if the generator is 5.9 we can move to 5.9 only
There was a problem hiding this comment.
Sorry that was some misinformation, the generator is still on 5.8.
But again, it won't cause problems on 5.8.
There was a problem hiding this comment.
Alright i've updated the PR to be 5.9-only in anticipation of the 1.0.0 swift-openapi-generator release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
ExistentialAnyandStrictConcurrencycompiler flags.