Skip to content

fix display unit #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix display unit #64

merged 1 commit into from
Sep 15, 2021

Conversation

avolokhov
Copy link
Contributor

A small concurrency fix for a bug introduced in #59

Checklist

  • [ + ] The provided tests still run.
  • [ + ] I've created new tests where needed.
  • [ N/A ] I've updated the documentation if necessary.

Motivation and Context

just a small bug fix for thread safe access to summary displayUnit

Description

I touched display unit in one of the tests so it will be caught by TSAN if it ever breaks again.

@avolokhov
Copy link
Contributor Author

cc @tomerd

@ktoso ktoso requested a review from MrLotU September 15, 2021 15:39
ktoso
ktoso approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for following up on it

@ktoso ktoso merged commit 0353a78 into swift-server:master Sep 15, 2021
@ktoso ktoso added this to the 1.0.0 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@MrLotU MrLotU Awaiting requested review from MrLotU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@avolokhov @ktoso