Make sure we return after gracefully shutdown #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
approved these changes
Jan 24, 2024
# Motivation After calling `shutdownGracefully` in our `ServiceGroup` we know that one of two things happened: 1. We got an error so something went wrong 2. We got no error so all services finished In the 2. case, there might still be a few child tasks in the task group e.g. the graceful shutdown timeout task. We are currently still iterating the remaining child task results which might lead into unexpected fatal errors. # Modification This PR makes sure that after we have successfully shutdown we are stopping iterating the child task results. # Result No more unexpected fatal errors.
FranzBusch
force-pushed
the
fb-fix-graceful-shutdown-signal
branch
from
c0efd9c to
4822be5
Compare
|
@swift-server-bot test this please |
FranzBusch
force-pushed
the
fb-fix-graceful-shutdown-signal
branch
from
58db08a to
c3cb5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After calling
shutdownGracefullyin ourServiceGroupwe know that one of two things happened:In the 2. case, there might still be a few child tasks in the task group e.g. the graceful shutdown timeout task. We are currently still iterating the remaining child task results which might lead into unexpected fatal errors.
Modification
This PR makes sure that after we have successfully shutdown we are stopping iterating the child task results.
Result
No more unexpected fatal errors.