[Database] Make the database path unique to the specific lmdb wrapper instance #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
akyrtzi
commented
Jul 10, 2020
lib/Database/Database.cpp
Outdated
| @@ -71,29 +71,39 @@ static int filesForProvider_compare(const MDB_val *a, const MDB_val *b) { | |||
| return IDCode::compare(lhs->UnitCode, rhs->UnitCode); | |||
| } | |||
|
|
|||
| /// Returns a global serial queue for unit processing. | |||
There was a problem hiding this comment.
Oops, copy-pasted the comment and forgot to update it.
benlangmuir
approved these changes
Jul 10, 2020
|
I also forgot to re-generate the linux tests 🤦♂️ |
… instance This is intended to protect against a crash that can occur if trying to use the same lmdb database path from separate wrapper instances. rdar://39235399
|
@swift-ci Please test |
TSan seems to trigger a false positive with this test.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to protect against a crash that can occur if trying to use the same lmdb database path from separate wrapper instances.
rdar://39235399