build: disable POSIX mutexes on Windows #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionalize the define to use POSIX mutexes to macOS and Linux targets. This would be easier to define as non-POSIX, but the package description does not have the negative check nor a POSIX check. This requires bumping the tools version to 5.3 to gain access to Windows.
|
@swift-ci please test |
|
This cannot be merged right now, I want to let the test finish before I update it; I just realized that this would cause a problem for older versions of spm, I'll add a workaround. |
|
Never mind, I didn't use |
We should not do this until 5.3 is released. Now that you're not using |
|
Ah, right you are. Not using |
|
@swift-ci please test |
benlangmuir
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionalize the define to use POSIX mutexes to macOS and Linux
targets. This would be easier to define as non-POSIX, but the package
description does not have the negative check nor a POSIX check.
This requires bumping the tools version to 5.3 to gain access to
Windows.