Remove all Uses of TimeValue #12
Conversation
lib/Database/ImportTransaction.cpp
Outdated
| TimestampedFileForProviderData entry{file, unit, module, modTime.seconds(), modTime.nanoseconds(), isSystem}; | ||
| auto nanos = std::chrono::duration_cast<std::chrono::nanoseconds>(modTime.time_since_epoch()).count(); | ||
| auto secComponent = nanos / 1000000000; | ||
| int32_t nanoComponent = nanos % 1000000000; |
There was a problem hiding this comment.
This changes the interpretation of any existing index data. TimeValue's internal epoch was/is 00:00:00 Jan 1, 2000 UTC, but this changes it to store the time using system_clock's epoch, which is probably the posix epoch in 1970.
I think we need to bump DATABASE_FORMAT_VERSION CC @akyrtzi to verify this.
@akyrtzi since we need to bump the format anyway, is there a reason we need to split up the time into components like this? Could we store a std::chrono::time_point<std::chrono::system_clock, nanoseconds> directly instead (we'd want to use that instead of TimePoint<> to guard against changes in llvm)?
There was a problem hiding this comment.
@akyrtzi since we need to bump the format anyway, is there a reason we need to split up the time into components like this? Could we store a
std::chrono::time_point<std::chrono::system_clock, nanoseconds>directly instead
I agree, we should store this as a single uint64 and bump the database format.
lib/Database/ImportTransaction.cpp
Outdated
| @@ -174,7 +177,8 @@ void ImportTransaction::Implementation::addFileAssociationForProvider(IDCode pro | |||
| lmdb::val existingValue; | |||
| cursor.get(existingKey, existingValue, MDB_GET_CURRENT); | |||
| const auto &existingData = *(TimestampedFileForProviderData*)existingValue.data(); | |||
| llvm::sys::TimeValue existingModTime(existingData.Seconds, existingData.Nanoseconds); | |||
| llvm::sys::TimePoint<> existingModTime = std::chrono::time_point_cast<std::chrono::nanoseconds>(llvm::sys::toTimePoint(existingData.Seconds)); | |||
There was a problem hiding this comment.
toTimePoint assumes you're converting from a time_t. We should only do that if we're using toTimeT on the other side.
The lastest version of llvm no longer has TimeValue.h, so this replaces uses with TimePoint and std::chrono.
gmittert
force-pushed
the
NoTimeComeQuick
branch
from
be8f03b to
08f0389
Compare
|
Updated the database version and now use |
|
@swift-ci please test |
The latest version of llvm no longer has TimeValue.h, so this replaces uses
with TimePoint and std::chrono.
I'd like to start porting this to Windows and as part of that, I need to pull in the Windows headers which means updating the llvm support libraries that are part of indexstore-db.