Remove LLVM_EXPORT references #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
suggested changes
Mar 25, 2019
gmittert
force-pushed
the
RemoveLLVMEXPORT
branch
from
423de1c to
5561e35
Compare
Fair enough! |
gmittert
force-pushed
the
RemoveLLVMEXPORT
branch
from
5561e35 to
9514343
Compare
benlangmuir
reviewed
Mar 29, 2019
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors |
| #ifndef LLVM_INDEXSTOREDB_SUPPORT_VISIBILITY_H | ||
| #define LLVM_INDEXSTOREDB_SUPPORT_VISIBILITY_H | ||
|
|
||
| #if __has_attribute(visibility) |
There was a problem hiding this comment.
#ifndef __has_attribute
#define __has_attribute(x) 0
#endif
LLVM_EXPORT no longer exists in LLVM so we define it instead now
gmittert
force-pushed
the
RemoveLLVMEXPORT
branch
from
9514343 to
bfd6478
Compare
|
@swift-ci please test |
benlangmuir
approved these changes
Mar 29, 2019
|
Build is running, but the status isn't showing up for some reason. I'll verify it manually once it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM_EXPORT no longer exists in llvm, remove it in preparation to pull in a new version