Skip to content

Workaround corelibs-libdispatch crash SR-10319 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

benlangmuir
Copy link
Contributor

@benlangmuir benlangmuir requested a review from akyrtzi as a code owner June 22, 2019 01:26
@benlangmuir
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pull out the common block literal so it's not duplicated and needing to update both of them ?

Otherwise if we do some global rename to the code it will only touch one preprocessor block and the other will be broken.

@benlangmuir
Copy link
Contributor Author

Good idea. Also fix the unbalanced Block_release on the Linux path by inserting a copy.

@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir
Copy link
Contributor Author

The PR tests passed (https://ci.swift.org/job/swift-indexstore-db-PR-Linux/27/ and https://ci.swift.org/job/swift-indexstore-db-PR-macOS/26/). Not sure why that status isn't showing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants