Add SymbolRelation class with roles and symbols #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literalpie
commented
Jul 11, 2019
benlangmuir
suggested changes
Jul 12, 2019
literalpie
commented
Jul 13, 2019
There was a problem hiding this comment.
You can see how this looks from the SourceKit-LSP side in my branch here
literalpie
force-pushed
the
symbol-relation
branch
from
7771960 to
f8a8ee8
Compare
benlangmuir
reviewed
Jul 15, 2019
| public final class SymbolRelation { | ||
| let value: indexstoredb_symbol_relation_t | ||
|
|
||
| public lazy var roles = SymbolRole(rawValue: indexstoredb_symbol_relation_get_roles(value)) |
There was a problem hiding this comment.
Please add type annotations (: SymbolRole) to any class/struct properties. It makes the API more explicit and can improve compile times.
literalpie
force-pushed
the
symbol-relation
branch
from
bb1df14 to
1de6594
Compare
|
Thanks! I think the type annotation for |
Add IndexSymbolKind enum Add kind property in Symbol Add forEachRelation of occurrence function
literalpie
force-pushed
the
symbol-relation
branch
from
1de6594 to
31dadcd
Compare
benlangmuir
approved these changes
Jul 16, 2019
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kind property to Symbol
Add forEachRelation of occurrence function
Based on discussions in workspace/symbol PR in apple/sourcekit-lsp.