Skip to content

Add Support for CRLF when Parsing Ninja Output #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

Add Support for CRLF when Parsing Ninja Output #46

merged 1 commit into from
Aug 13, 2019

Conversation

gmittert
Copy link
Contributor

On Windows, Ninja outputs CRLF instead of just an LF.

@benlangmuir
Copy link
Contributor

Please rebase on current master.

@gmittert
Add Support for CRLF when Parsing Ninja Output
9ab6b93 
On Windows, Ninja outputs CRLF instead of just an LF.
@gmittert
Copy link
Contributor Author

@swift-ci please test and merge

@benlangmuir
Copy link
Contributor

@swift-ci please test

1 similar comment
@benlangmuir
Copy link
Contributor

@swift-ci please test

@benlangmuir benlangmuir merged commit aecdc01 into swiftlang:master Aug 13, 2019
@gmittert gmittert deleted the SneakyNewlines branch August 13, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmittert @benlangmuir