Fix Ninja Output for Windows #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
reviewed
Aug 13, 2019
- Ninja requires that `:`s in filenames be escaped as `$:` - Explicitly call cmd.exe /C on Windows - In addition, escape spaces for the command that we pass to cmd.exe
gmittert
force-pushed
the
WindowsPathsMakeMeSad
branch
from
02e2a52 to
0a02e5d
Compare
|
Moved functions out of the class, rebased, and fixed indentation @swift-ci please test |
benlangmuir
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:s in filenames be escaped as$:I stole the command line quoting verbatim from the one I wrote for Foundation.