[llvm] Mangle all llvm symbols to avoid collisions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ended up deciding to fix the linking issues around llvm in a different way, so this was unnecessary. If someone needs it we can easily bring it back.
Adds an #include of a prefix header to every imported llvm file so that we can use this to customize certain behaviours specifically for indexstore-db. Clang has support for including prefix headers, but swiftpm doesn't have a way to access it, so we use this instead.
Rename all of the llvm symbols so that they will not collide if another copy of llvm is linked into the same image. The use of llvm within IndexStore is purely an implementation detail. Using a source-level rename is a workaround for the lack of symbol visibility controls in swiftpm. Ideally we could do this with a combination of `-fvisibility=hidden` and `ld -r`. This allows us to link into sourcekit-lsp statically without colliding with symbols in llbuild.
akyrtzi
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all of the llvm symbols so that they will not collide if another copy of llvm is linked into the same image. The use of llvm within IndexStore is purely an implementation detail. Using a source-level rename is a workaround for the lack of symbol visibility controls in swiftpm. Ideally we could do this with a combination of
-fvisibility=hiddenandld -r.This allows us to link into sourcekit-lsp statically without colliding with symbols in llbuild.