Expose the name of every symbol in the index #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the name of every symbol in the index
akyrtzi
suggested changes
Mar 13, 2020
| } | ||
|
|
||
| /// Returns a set with every symbol in the index. | ||
| public func allSymbolNames() -> Set<String> { |
There was a problem hiding this comment.
This doesn't need to be a Set, indexstoredb_index_symbol_names is going to return unique strings.
I'd recommend to change it to array.
Add tests for IndexStoreDB.allSymbolNames()
akyrtzi
approved these changes
Mar 13, 2020
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where one wants to iterate through the list of all the symbols in the index. Such functionality exists in the underlying lower-level library.
This PR makes that functionality available to
indexstore-dbusers.