Skip to content

Collect the dependency info and process them outside of the libIndexStore callback #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Collect the dependency info and process them outside of the libIndexStore callback #76

merged 1 commit into from
Mar 24, 2020

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Mar 24, 2020

This is because processing populates the database and C++ exceptions can be thrown; libIndexStore builds with -fno-exceptions so we cannot be throwing C++ exceptions from inside its frames.

rdar://60611975

…tore callback

This is because processing populates the database and C++ exceptions can be thrown; libIndexStore builds with -fno-exceptions so we cannot be throwing C++ exceptions from inside its frames.

rdar://60611975
@akyrtzi akyrtzi requested a review from benlangmuir as a code owner March 24, 2020 19:08
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Mar 24, 2020

@swift-ci Please test

@akyrtzi akyrtzi merged commit 2be42a6 into swiftlang:master Mar 24, 2020
@akyrtzi akyrtzi deleted the no-cpp-exceptions-via-libindexstore branch March 24, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants