Skip to content

Commit 0c27db5

Browse files
Merge pull request #4199 from adrian-prantl/91291458
Simplify NativeHashedStorageHandler()
2 parents c6652f6 + 2ed64cb commit 0c27db5

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

lldb/source/Plugins/Language/Swift/SwiftHashedContainer.cpp

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -459,20 +459,11 @@ NativeHashedStorageHandler::NativeHashedStorageHandler(
459459
std::vector<TypeSystemSwift::TupleElement> tuple_elements{
460460
{g_key, key_type}, {g_value, value_type}};
461461
m_element_type = type_system->CreateTupleType(tuple_elements);
462-
auto *swift_type =
463-
m_element_type.GetCanonicalType().GetOpaqueQualType();
464-
auto element_stride = m_element_type.GetByteStride(m_process);
465-
if (element_stride) {
462+
if (auto result = runtime->GetMemberVariableOffset(
463+
m_element_type, nativeStorage_sp.get(), "1"))
464+
m_key_stride_padded = *result;
465+
else if (auto element_stride = m_element_type.GetByteStride(m_process))
466466
m_key_stride_padded = *element_stride - m_value_stride;
467-
}
468-
if (type_system->IsTupleType(swift_type)) {
469-
Status error;
470-
llvm::Optional<uint64_t> result = runtime->GetMemberVariableOffset(
471-
{type_system, swift_type}, nativeStorage_sp.get(), "1",
472-
&error);
473-
if (result)
474-
m_key_stride_padded = result.getValue();
475-
}
476467
}
477468
} else {
478469
m_element_type = key_type;

0 commit comments

Comments
 (0)